-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEM Mass matrix element assembly kernel #330
Conversation
@rhornung67 @MrBurmark could I get a review on this PR? |
@rhornung67 I added some notes on the z-loops with an iteration space of [0,1) that the kernels have. Let me know if it makes sense; I can expand more. |
My opinion on the "extra" length 1 loops is that if they are not necessary in some of the Base/Lambda implementations its fine to remove them. It seems like in this case that is how you would naturally code up the native variants of the implementation. On the other hand its important for the RAJA implementation to be single source and the same for all RAJA variants because that is how we write RAJA code. |
TODO: Remove extra loop in host base variants with iteration range [0, 1) |
Kernel for element local mass matrix assembly