Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts honor user PYTHONPATH #26

Merged
merged 1 commit into from
Apr 28, 2021
Merged

scripts honor user PYTHONPATH #26

merged 1 commit into from
Apr 28, 2021

Conversation

lee218llnl
Copy link
Collaborator

enhancement suggested in #25

@coveralls
Copy link

Pull Request Test Coverage Report for Build 572

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.468%

Totals Coverage Status
Change from base Build 568: 0.0%
Covered Lines: 3378
Relevant Lines: 10404

💛 - Coveralls

Copy link

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but just just curious why not to just do:

export PYTHONPATH=@pythondir@:@pyexecdir@:@PYTHONPATH@:$PYTHONPATH

If PYTHONPATH is empty then we get : extra at the end and it's valid anyway.

@lee218llnl
Copy link
Collaborator Author

LGTM but just just curious why not to just do:

export PYTHONPATH=@pythondir@:@pyexecdir@:@PYTHONPATH@:$PYTHONPATH

If PYTHONPATH is empty then we get : extra at the end and it's valid anyway.

@pramodk anecdotally, I have seen issues before where a dangling ':' character can cause issues with various *PATH variables. I don't remember if it was specifically PYTHONPATH or perhaps PATH or LD_LIBRARY_PATH, but as a precaution, I check *PATH environment variables.

@lee218llnl lee218llnl merged commit 91872f9 into develop Apr 28, 2021
@lee218llnl lee218llnl deleted the pythonpath branch April 29, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants