-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candidate for v0.8.1 (#1154) #1158
Conversation
I don't understand how there is a conflict reported in scripts/spack/packages/axom/package.py. I don't see it on the "Changed files" tab. I'd appreciate some help with this. |
@agcapps the github review UI may not show files changed that are also conflicts |
Can you click, "resolve conflicts" to see the issue? |
I can't click "resolve conflicts," so we will have to use git outside the Github UI. |
I don't know our workflow for getting a release version, so maybe this is nothing, but... I see that I can merge |
I agree. I don't understand the logic. To fix, please approve #1159 . I will merge that into develop. Then I can merge this PR. |
@agcapps -- something seems off with this PR -- if you're merging back from It's not clear to me why there are merge conflicts or 46 file changes. Is it possible that your develop and/or main branches weren't up to date before creating this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that we need to close this PR and create a new one to merge main
back into develop
-- there should only be a few small changes related to the changed version.
V0.8.1 rc