-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print target properties recursively and with regular expressions #590
Print target properties recursively and with regular expressions #590
Conversation
@chapman39 don't forget to update the docs here: docs/api/target_properties.rst As well as adding a message in the RELEASE-NOTES.md |
Co-authored-by: Chris White <white238@llnl.gov>
… github.com:LLNL/blt into feature/chapman39/print_target_properties_recursive
Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! This will be very useful for debugging. Had some minor comments on documentation.
cmake/BLTPrivateMacros.cmake
Outdated
## blt_find_target_dependencies(TARGET <target> TLIST tlist) | ||
## | ||
## Store all target's dependencies (link libraries and interface link libraries) | ||
## recursively in TLIST. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## recursively in TLIST. | |
## recursively in tlist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it should still be capital TLIST but ill change the wording to explain TLIST holds the name of the variable that has the list.
so its like:
- arg_TLIST = "my_list"
- ${arg_TLIST} = my_list = "target1;target2;target3"
Also: Looks like the Mac Image version will need to be updated: https://dev.azure.com/llnl-blt/BLT/_build/results?buildId=1328&view=logs&j=8dab7c2a-824f-53c4-ff36-17cdfa82e5d3 Lines 53 to 55 in 7b3b13d
|
Well i was originally going to say address this after but its blocking the builds. @chapman39 can you fix this before merging? |
Passing osx_gcc, but now I'm failing three of the gitlab tests since it's saying I'm an unauthorized user (or maybe it's referring to a service user?) |
Not sure what the problem was. I retried and it passed. |
Co-authored-by: Chris White <white238@llnl.gov>
… github.com:LLNL/blt into feature/chapman39/print_target_properties_recursive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chapman39 ! This is a huge improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chapman39 -- I'm looking forward to using this!
message(STATUS "") | ||
message(STATUS "Exercising blt_print_target_properties macro. Testing infinite recursion") | ||
blt_register_library(NAME foo DEPENDS_ON bar) | ||
blt_register_library(NAME bar DEPENDS_ON foo) | ||
blt_print_target_properties(TARGET bar CHILDREN true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Adds three more arguments to blt_print_target_properties
Each target will only have its properties printed once
Also adds .gitignore file to ignore a VSCode file