Replacing Corona with Tioga in CI #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapman39
added
CI
…com:LLNL/blt into feature/chapman39/replace_corona_with_tioga
white238
approved these changes
Sep 13, 2022
white238
reviewed
Sep 13, 2022
|
|
||
| set(CMAKE_Fortran_COMPILER "/opt/rocm-5.1.1/llvm/bin/amdflang" CACHE PATH "") | ||
|
|
||
| set(CMAKE_Fortran_FLAGS "-Mfreeform" CACHE STRING "") |
There was a problem hiding this comment.
This fortran flag is specific to Axom and i think can be safely removed.
bmhan12
approved these changes
Sep 13, 2022
bmhan12
requested changes
Sep 13, 2022
There was a problem hiding this comment.
There is a failure in processing the tioga cmake file.
https://lc.llnl.gov/gitlab/blt/blt/-/pipelines/204990
It's looking for the file at path:
host-configs/llnl/toss_4_x86_64_ib_cray/tioga-toss_4_x86_64_ib_cray-clang@14.0.0_hip.cmake
bmhan12
reviewed
Sep 13, 2022
.gitlab/build_tioga.yml
Outdated
| tioga-clang_14_0_0_hip: | ||
| variables: | ||
| COMPILER: "clang@14.0.0_hip" | ||
| HOST_CONFIG: "tioga-toss_4_x86_64_ib_cray-${COMPILER}.cmake" |
There was a problem hiding this comment.
Either this HOST_CONFIG variable here or the host-config file name itself needs to change to match, I think.
There was a problem hiding this comment.
That was definitely the issue, thanks.
bmhan12
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.