Fixes crayftn + hip
#608
Merged
Fixes crayftn + hip
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white238
added
flags
white238
commented
Nov 18, 2022
| @@ -3,14 +3,11 @@ | |||
| # | |||
| # SPDX-License-Identifier: (BSD-3-Clause) | |||
|
|
|||
| # Author: Noel Chalmers @ Advanced Micro Devices, Inc. | |||
There was a problem hiding this comment.
This no longer bears any relevance to what he originally wrote. This should have been removed when @davidbeckingsale completely rewrote this logic.
white238
commented
Nov 18, 2022
cmake/thirdparty/SetupHIP.cmake
Outdated
Comment on lines
69
to
76
| if(CMAKE_Fortran_COMPILER_ID STREQUAL "Cray") | ||
| set(_blt_hip_compile_flags "$<$<COMPILE_LANGUAGE:CXX>:SHELL:--rocm-path=${ROCM_PATH}>") | ||
| else() | ||
| set(_blt_hip_compile_flags "--rocm-path=${ROCM_PATH}") | ||
| endif() | ||
|
|
||
| blt_import_library(NAME blt_hip | ||
| COMPILE_FLAGS ${_blt_hip_compile_flags} |
There was a problem hiding this comment.
This is the fix. The rest is just consistent formatting.
There was a problem hiding this comment.
It turns out that while crayftn < 15 doesn't support the flag crayftn 15 does and we probably actually want to use it when we can?
There was a problem hiding this comment.
added a check for this too. Thanks @tomstitt !
bmhan12
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #607
Fix originally from Burl Hall! Thanks Burl!