Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EventProxy does not support getting non-erased event #51

Closed
MrBurmark opened this issue Apr 23, 2021 · 1 comment · Fixed by #54
Closed

EventProxy does not support getting non-erased event #51

MrBurmark opened this issue Apr 23, 2021 · 1 comment · Fixed by #54
Assignees
@trws

Comments

@MrBurmark
Copy link
Member

It would be convenient to be able to get a non-erased event type from EventProxy. It seems wasteful to create an erased event when type information is available.
@trws
Copy link
Member

trws commented Apr 27, 2021

I agree, we actually seem to have an interface problem I hadn't considered before as well. The wait_for method always takes not only a pointer to an event, but a pointer to a type-erased event. I can add support for this easily, and will shortly, but using strongly typed events is not terribly convenient right now, and I think that's going to need some thought.

@trws trws self-assigned this Apr 27, 2021
trws added a commit to trws/camp that referenced this issue Apr 27, 2021
@trws
support getting non-erased event from EventProxy
6168138 
Fixes LLNL#51

Add support for getting the native event type out of EventProxy.
This is now the default, with Event fixed to allow implicit conversion
from native event types and a new `operator Event()` overload on
EventProxy all tests pass in tree, need to see how this impacts codes.
@trws trws mentioned this issue Apr 27, 2021
Merged
trws added a commit to trws/camp that referenced this issue Jul 21, 2021
@trws
support getting non-erased event from EventProxy
8c6c48f 
Fixes LLNL#51

Add support for getting the native event type out of EventProxy.
This is now the default, with Event fixed to allow implicit conversion
from native event types and a new `operator Event()` overload on
EventProxy all tests pass in tree, need to see how this impacts codes.
trws added a commit to trws/camp that referenced this issue Aug 3, 2021
@trws
support getting non-erased event from EventProxy
b4d4900 
Fixes LLNL#51

Add support for getting the native event type out of EventProxy.
This is now the default, with Event fixed to allow implicit conversion
from native event types and a new `operator Event()` overload on
EventProxy all tests pass in tree, need to see how this impacts codes.
@trws trws closed this as completed in #54 Aug 3, 2021
trws added a commit that referenced this issue Aug 3, 2021
@trws
support getting non-erased event from EventProxy
e08f1f2 
Fixes #51

Add support for getting the native event type out of EventProxy.
This is now the default, with Event fixed to allow implicit conversion
from native event types and a new `operator Event()` overload on
EventProxy all tests pass in tree, need to see how this impacts codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trws trws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for native events from EventProxy trws/camp
2 participants
@trws @MrBurmark