New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_platform a const method #133

Merged

trws merged 2 commits into LLNL:main from MrBurmark:bugfix/burmark1/get_platform_const

Jun 2, 2023

Member

MrBurmark commented Jun 1, 2023

There may not be many things you can do with a const resource but getting the platform seems reasonable.

MrBurmark added 2 commits

June 1, 2023 09:11


          Make get_platform a const method

9b094e0


          Test get_platform on const resource

2e4d2be

MrBurmark requested review from davidbeckingsale and trws

June 1, 2023 16:15

trws approved these changes

View reviewed changes

Member

trws left a comment

Sounds right to me. Here's looking forward to C++20 when we can mark that one constexpr too. 😁

trws merged commit f06c7a1 into LLNL:main

14 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment