Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard size/length 0 things for CUDA #27

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Guard size/length 0 things for CUDA #27

merged 2 commits into from
Apr 16, 2020

Conversation

davidbeckingsale
Copy link
Member

No description provided.

@davidbeckingsale
Copy link
Member Author

Fixes issue in RAJA scan tests when the length of the array is 0.

@rhornung67
Copy link
Member

@davidbeckingsale thanks for the quick fix. It would be helpful if we could check things like this with some CI tests on GitHub. I guess that means we should work on getting the Gitlab CI stuff working for RAJA....

Copy link
Member

@trws trws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidbeckingsale, my only quibble is that the check for null before free is unnecessary. Just like regular free it's guaranteed to do that check internally.

@davidbeckingsale
Copy link
Member Author

Got it, fixed @trws.

@trws
Copy link
Member

trws commented Apr 16, 2020

As soon as travis comes back green, I'll merge, thanks again @davidbeckingsale!

@davidbeckingsale
Copy link
Member Author

Note that this will require bumping RAJA's camp tpl, and also removing a bugfix left in the StaticLayout header.

@trws trws merged commit 0775286 into master Apr 16, 2020
@rhornung67
Copy link
Member

Thanks for the quick fix guys. I'll put up a PR to update the camp version in RAJA to this.

@trws trws deleted the bugfix/cuda-verify-size branch September 10, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants