-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard size/length 0 things for CUDA #27
Conversation
Fixes issue in RAJA scan tests when the length of the array is 0. |
@davidbeckingsale thanks for the quick fix. It would be helpful if we could check things like this with some CI tests on GitHub. I guess that means we should work on getting the Gitlab CI stuff working for RAJA.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidbeckingsale, my only quibble is that the check for null before free is unnecessary. Just like regular free it's guaranteed to do that check internally.
Got it, fixed @trws. |
As soon as travis comes back green, I'll merge, thanks again @davidbeckingsale! |
Note that this will require bumping RAJA's camp tpl, and also removing a bugfix left in the StaticLayout header. |
Thanks for the quick fix guys. I'll put up a PR to update the camp version in RAJA to this. |
No description provided.