Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add get_event_erased to resource class #66

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

artv3
Copy link
Member

@artv3 artv3 commented Jun 16, 2021

Since we pass back a erased resource type in LLNL/RAJA#1029, we need to add get_event_erased method class to the resource class.

Copy link
Member

@trws trws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested change, or an equivalent one, I'm good with this.

include/camp/resource.hpp Outdated Show resolved Hide resolved
Co-authored-by: Tom Scogland <tom.scogland@gmail.com>
@trws
Copy link
Member

trws commented Jul 6, 2021

@artv3: Error from Travis, looks like the ContextInterface doesn't have the method to pass it through:

1: /home/raja/include/camp/resource.hpp:94:50: error: 'class camp::resources::v1::Resource::ContextInterface' has no member named 'get_event_erased'

@artv3
Copy link
Member Author

artv3 commented Jul 21, 2021

Thanks @trws, could we sync up after the release to try to fix this? I'm off the next few days but hopefully after we can sort it out.
This PR is needed for the following RAJA branch - LLNL/RAJA#1029.

@trws
Copy link
Member

trws commented Jul 21, 2021

Sure. The problem should be solved by adding a get_event_erased right next to the get_event proxy method here.

@artv3
Copy link
Member Author

artv3 commented Jul 21, 2021

Hooray! all test pass!

Copy link
Member

@trws trws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@trws trws merged commit e1ace9b into LLNL:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants