-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add get_event_erased to resource class #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the suggested change, or an equivalent one, I'm good with this.
Co-authored-by: Tom Scogland <tom.scogland@gmail.com>
@artv3: Error from Travis, looks like the ContextInterface doesn't have the method to pass it through:
|
Thanks @trws, could we sync up after the release to try to fix this? I'm off the next few days but hopefully after we can sort it out. |
Sure. The problem should be solved by adding a |
Hooray! all test pass! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Since we pass back a erased resource type in LLNL/RAJA#1029, we need to add get_event_erased method class to the resource class.