resolved random crash in t_relay_mpi_test

the issue was a mismatch in a waitall between the number of messages sent and the count to wait for. https://stackoverflow.com/questions/8418716/why-wont-mpi-finalize-gracefully
LLNL · Jul 22, 2017 · 7bb3bd2 · 7bb3bd2
1 parent 397dc1d
commit 7bb3bd2
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 161 deletions.
diff --git a/run_stress.py b/run_stress.py
diff --git a/src/tests/relay/CMakeLists.txt b/src/tests/relay/CMakeLists.txt
@@ -57,7 +57,7 @@ set(RELAY_TESTS t_relay_smoke
 ################################
 # Optional Unit Tests
 ################################
-set(RELAY_MPI_TESTS      t_relay_mpi_smoke t_relay_mpi_test t_relay_mpi_test_crash)
+set(RELAY_MPI_TESTS      t_relay_mpi_smoke t_relay_mpi_test)
 set(RELAY_SILO_TESTS     t_relay_io_silo)
 
 set(RELAY_HDF5_TESTS t_relay_io_hdf5 

diff --git a/src/tests/relay/t_relay_mpi_test.cpp b/src/tests/relay/t_relay_mpi_test.cpp
@@ -585,13 +585,13 @@ TEST(conduit_mpi_test, waitallmultirequest)
     {
         mpi::irecv(n1, 1, 0, MPI_COMM_WORLD, &requests[0]);
         mpi::irecv(n2, 1, 0, MPI_COMM_WORLD, &requests[1]);
-        mpi::wait_all_recv(1, requests, statuses);
+        mpi::wait_all_recv(2, requests, statuses);
     }
     else if (rank == 1) 
     {
         mpi::isend(n1, 0, 0, MPI_COMM_WORLD, &requests[0]);
         mpi::isend(n2, 0, 0, MPI_COMM_WORLD, &requests[1]);
-        mpi::wait_all_send(1, requests, statuses);
+        mpi::wait_all_send(2, requests, statuses);
     }
 
     EXPECT_EQ(n1.as_float64_ptr()[0], 2);

diff --git a/src/tests/relay/t_relay_mpi_test_crash.cpp b/src/tests/relay/t_relay_mpi_test_crash.cpp