Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve unnecessary cmake transitive link dep for civet and b64 #16

Closed
cyrush opened this issue Jul 30, 2016 · 1 comment
Closed

resolve unnecessary cmake transitive link dep for civet and b64 #16

cyrush opened this issue Jul 30, 2016 · 1 comment
Labels
task
Milestone
0.2.0

Comments

@cyrush
Copy link
Member

cyrush commented Jul 30, 2016

related to #14, we should try to resolve the underlying issue with PRIVATE causing a transitive link dependency for imported targets
@cyrush cyrush added the task label Jul 30, 2016
@cyrush cyrush changed the title resolve unnecessary cmake transitive link dep for civet and bb64 resolve unnecessary cmake transitive link dep for civet and b64 Aug 6, 2016
@cyrush cyrush mentioned this issue Aug 10, 2016
Closed
cyrush added a commit that referenced this issue Aug 10, 2016
@cyrush
enh: rename b64 and civetweb targets and libs
20d52f3 
to avoid potential conflicts for system installs:

renamed b64 to conduit_b64
renamed civetweb to conduit_civetweb

These are only used internally, but are always installed -- due
to github issue #16
@cyrush cyrush mentioned this issue Aug 10, 2016
Merged
@cyrush
Copy link
Member Author

cyrush commented Sep 25, 2016 •
edited
Loading

the best solution for this is to simply use a cmake object library for b64 & civetweb:

https://cmake.org/Wiki/CMake/Tutorials/Object_Library

@cyrush cyrush added this to the 0.2.0 milestone Sep 25, 2016
cyrush added a commit that referenced this issue Sep 25, 2016
@cyrush
enh: use object libs for b64 and civet
25231f9 
change our cmake setup to use object libs for b64 and civet
this should resolve #16

gap inst for DataArray templates
add proper export decorations for the entire node c-api
add mising export decoration for a method in relay_web
add mising export decoration to Node::Value and Node:ConstValue
@cyrush cyrush mentioned this issue Sep 30, 2016
Merged
@cyrush cyrush closed this as completed in b68ddc3 Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@cyrush