Add pyramid and wedge support #1023
Conversation
| //---------------------------------------------------------------------------// | ||
| inline float64 braid_init_example_point_scalar_field_calc_dx(index_t npts_x) | ||
| { | ||
| return (float) (4.0 * PI_VALUE) / float64(npts_x - 1); | ||
| } | ||
|
|
||
|
|
||
| //---------------------------------------------------------------------------// | ||
| inline float64 braid_init_example_point_scalar_field_calc_dy(index_t npts_y) | ||
| { | ||
| return (float) (2.0 * PI_VALUE) / float64(npts_y-1); | ||
| } | ||
|
|
||
|
|
||
| //---------------------------------------------------------------------------// | ||
| inline float64 braid_init_example_point_scalar_field_calc_dz(index_t npts_z) | ||
| { | ||
| return (float) (3.0 * PI_VALUE) / float64(npts_z-1); | ||
| } |
There was a problem hiding this comment.
How do we feel about these? I did this instead of hard coding the calculation wherever it was needed.
There was a problem hiding this comment.
The most general way would be to eval at a specific x,y,z instead of the dx,dy,dz.
Should be an easy refactor, what do you think?
There was a problem hiding this comment.
Why did I do this? If I remember correctly, it was because I didn't want to recalculate dx, dy, and dz for each x,y,z I am using to calculate the field val. There is a function (below, probably?) that calculates the field val for a given x,y,z and dx,dy,dz. Does that make sense?
JustinPrivitera
requested review from
agcapps
and removed request for
cyrush and
agcapps
|
Suggestion I don't want to forget: Please add a Changelog entry. |
|
Angle of the pictures looks good! I would crop them down a bit so they fill more space on the docs page. https://llnl-conduit--1023.org.readthedocs.build/en/1023/blueprint_mesh.html#pyramids (compare pyramids with the hexs visual) We also need the yaml output of the bluperint tree for wedges and pyramids. And there is a small typo with the wedges entry ref in the table:
|
| @@ -932,6 +932,10 @@ supported values for this parameter and their corresponding effects are outlined | |||
| +--------------------------------+--------------------+-------------------+-------------------+------------------+ | |||
| | `hexs <Hexs_>`_ | 3d | explicit | explicit | hex | | |||
Hi. I left this in draft b/c I knew I still needed to fix up these last few things w/ the docs. Nice catch on the wedges entry ref in the table. I'll get to these very very soon 😄 I was hoping to get these last few things done before you reviewed, my bad. |
|
@JustinPrivitera yes, no worries, I had some time to review this morning so I wanted to see how things were going :-) |
|
Thanks, @JustinPrivitera ! |
I'll merge once I figure out the strangeness with silo... the silo version of wedges looks very different from the blueprint version. |
JustinPrivitera
deleted the
task/JustinPrivitera/09_30_22/pyramid_wedge_support
branch
Resolves #132
Adds support in the mesh blueprint for pyramids and wedges.
Adds versions of braid that are comprised of pyramids and wedges.
Once merged I'll put up a PR in VisIt for the bp plugin.
The following still need to be done: