Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to blt 0.6.0 #1233

Merged
merged 13 commits into from
Jan 24, 2024
Merged

update to blt 0.6.0 #1233

merged 13 commits into from
Jan 24, 2024

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Jan 19, 2024

No description provided.

@cyrush
Copy link
Member Author

cyrush commented Jan 19, 2024

  • TODO: Remove commented old blt logic once the ci coast is clear.

@cyrush
Copy link
Member Author

cyrush commented Jan 19, 2024

Need to understand the true min version of CMake now -- 3.9.6 is too old:

-- CMake Version: 3.9.6
-- CMake Configuration Types: Debug;Release;MinSizeRel;RelWithDebInfo
-- CMake Executable: C:/Program Files/CMake/bin/cmake.exe
-- Setting CMAKE_CXX_EXTENSIONS to OFF
-- Standard C++14 selected
-- MPI Support is ON
-- FindMPI Enabled  (ENABLE_FIND_MPI == ON)
-- Found MPI_C: C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x86/msmpi.lib  
-- Found MPI_CXX: C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x86/msmpi.lib  
-- BLT MPI Compile Flags:  
-- BLT MPI Include Paths:  C:/Program Files (x86)/Microsoft SDKs/MPI/Include
-- BLT MPI Libraries:      C:/Program Files (x86)/Microsoft SDKs/MPI/Lib/x86/msmpi.lib
-- BLT MPI Link Flags:     
-- MPI Executable:       C:/Program Files/Microsoft MPI/Bin/mpiexec.exe
-- MPI Num Proc Flag:    -n
-- MPI Command Append:   
CMake Error at blt/cmake/BLTInstallableMacros.cmake:456 (target_include_directories):
  Cannot specify include directories for imported target "mpi".
Call Stack (most recent call first):
  blt/cmake/BLTInstallableMacros.cmake:544 (blt_convert_to_system_includes)
  blt/cmake/BLTInstallableMacros.cmake:618 (blt_patch_target)
  blt/cmake/thirdparty/BLTSetupMPI.cmake:187 (blt_import_library)
  blt/cmake/BLTSetupTargets.cmake:67 (include)
  blt/cmake/SetupThirdParty.cmake:6 (include)
  blt/SetupBLT.cmake:130 (include)
  cmake/SetupBLT.cmake:40 (include)
  CMakeLists.txt:63 (include)
CMake Error at blt/cmake/thirdparty/BLTSetupMPI.cmake:195 (add_library):
  add_library cannot create ALIAS target "blt::mpi" because target "mpi" is
  IMPORTED.
Call Stack (most recent call first):
  blt/cmake/BLTSetupTargets.cmake:67 (include)

@cyrush
Copy link
Member Author

cyrush commented Jan 19, 2024

cmake 3.14 -- also to old

-- CMake Version: 3.14.2
-- CMake Build Type: Debug
-- CMake Executable: /__w/1/s/uberenv_libs/spack/opt/spack/linux-ubuntu18.04-x86_64_v4/gcc-7.5.0/cmake-3.14.2-xy7srzpt5nkkuhbt2n4435b2xadqa3v6/bin/cmake
-- Setting CMAKE_CXX_EXTENSIONS to OFF
-- Standard C++11 selected
-- MPI Support is ON
-- FindMPI Enabled  (ENABLE_FIND_MPI == ON)
-- Found MPI_C: /usr/lib/x86_64-linux-gnu/libmpich.so (found version "3.1") 
-- Found MPI_CXX: /usr/lib/x86_64-linux-gnu/libmpichcxx.so (found version "3.1") 
-- Found MPI_Fortran: /usr/lib/x86_64-linux-gnu/libmpichfort.so (found version "3.1") 
-- Found MPI: TRUE (found version "3.1")  
-- BLT MPI Compile Flags:  
-- BLT MPI Include Paths:  /usr/include/mpich
-- BLT MPI Libraries:      /usr/lib/x86_64-linux-gnu/libmpich.so;/usr/lib/x86_64-linux-gnu/libmpichcxx.so;/usr/lib/x86_64-linux-gnu/libmpichfort.so
-- BLT MPI Link Flags:     SHELL:-Wl,-Bsymbolic-functions
-- MPI Executable:       /usr/bin/mpiexec
-- MPI Num Proc Flag:    -n
-- MPI Command Append:   
-- Using MPI Fortran header: mpif.h
-- OpenMP Support is ON
CMake Error at blt/cmake/thirdparty/BLTSetupMPI.cmake:195 (add_library):
  add_library cannot create ALIAS target "blt::mpi" because target "mpi" is
  imported but not globally visible.
Call Stack (most recent call first):
  blt/cmake/BLTSetupTargets.cmake:67 (include)
  blt/cmake/SetupThirdParty.cmake:6 (include)
  blt/SetupBLT.cmake:130 (include)
  cmake/SetupBLT.cmake:40 (include)
  CMakeLists.txt:63 (include)


-- Found OpenMP_C: -fopenmp (found version "4.5") 
-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
-- Found OpenMP_Fortran: -fopenmp (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
-- OpenMP Compile Flags: -fopenmp
-- OpenMP Link Flags:    -fopenmp
CMake Error at blt/cmake/thirdparty/BLTSetupOpenMP.cmake:60 (add_library):
  add_library cannot create ALIAS target "blt::openmp" because target
  "openmp" is imported but not globally visible.
Call Stack (most recent call first):
  blt/cmake/BLTSetupTargets.cmake:78 (include)
  blt/cmake/SetupThirdParty.cmake:6 (include)
  blt/SetupBLT.cmake:130 (include)
  cmake/SetupBLT.cmake:40 (include)
  CMakeLists.txt:63 (include)

@cyrush
Copy link
Member Author

cyrush commented Jan 22, 2024

  • Note: gtest vs python fix requires BLT PR and new BLT release.

But we are now using a commit off of BLT develop, we can switch to 0.6.1 when it is released.

@cyrush
Copy link
Member Author

cyrush commented Jan 24, 2024

merging, we will do 0.6.1 blt change later.

@cyrush cyrush merged commit 177c2f0 into develop Jan 24, 2024
25 checks passed
@cyrush cyrush deleted the task/2024_01_update_blt branch January 24, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant