Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash in relay mpi bcast with non empty recv nodes #419

Merged
merged 3 commits into from
Jun 15, 2019
Merged

fix crash in relay mpi bcast with non empty recv nodes #419

merged 3 commits into from
Jun 15, 2019

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Jun 15, 2019

Schema::compatible() doesn't give is the green light to zero copy complex types, so we need more checks to avoid crashes.

@cyrush
Copy link
Member Author

cyrush commented Jun 15, 2019 •
edited
Loading

resolves #418 and I believe #398

@cyrush cyrush mentioned this pull request Jun 15, 2019
Open
@cyrush cyrush changed the title fix crash in relay mpi bcast with non empty nodes fix crash in relay mpi bcast with non recv empty nodes Jun 15, 2019
@cyrush cyrush changed the title fix crash in relay mpi bcast with non recv empty nodes fix crash in relay mpi bcast with non empty recv nodes Jun 15, 2019
@coveralls
Copy link

coveralls commented Jun 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.809% when pulling 96bbba0 on task/2019_06_relay_mpi_bcast_crash into 5845b71 on master.

@cyrush cyrush merged commit e725071 into master Jun 15, 2019
@cyrush cyrush deleted the task/2019_06_relay_mpi_bcast_crash branch June 15, 2019 15:46
This was referenced Jun 15, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyrush @coveralls