Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py, c, fortran api: add_child, child, remove_child for node and schema #526

Merged
merged 4 commits into from Mar 25, 2020

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Mar 25, 2020

adds python wrappers and tests for new node and schema methods supporting child names with embedded slashes

@cyrush
Copy link
Member Author

cyrush commented Mar 25, 2020

TODO:

  • C Interface + Tests
  • FORTRAN Interface + Tests

@cyrush cyrush added this to the 0.6.0 milestone Mar 25, 2020
@cyrush
Copy link
Member Author

cyrush commented Mar 25, 2020

helps with #478

@cyrush
Copy link
Member Author

cyrush commented Mar 25, 2020

@HaluskaR FYI: Working on support for the new embedded slash support for Python, C and Fortran APIs

For python, there were other unwrapped methods for Schema that I also took care of -- so that represents more changes than usually necessary to wrap for Python.

@cyrush cyrush changed the title py api: add_child, child, remove_child for node and schema py, c, fortran api: add_child, child, remove_child for node and schema Mar 25, 2020
@coveralls
Copy link

coveralls commented Mar 25, 2020

Coverage Status

Coverage decreased (-0.06%) to 85.539% when pulling 677003f on task/2020_03_api_support_for_child into aa2de17 on master.

@cyrush cyrush merged commit bdd1bca into master Mar 25, 2020
@cyrush cyrush deleted the task/2020_03_api_support_for_child branch March 25, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants