Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amr examples #556

Merged
merged 13 commits into from
May 7, 2020
Merged

Amr examples #556

merged 13 commits into from
May 7, 2020

Conversation

mclarsen
Copy link
Contributor

@mclarsen mclarsen commented May 5, 2020

This includes :

  • a simple example of a small domain with a single child.
  • a complex example that can create an arbitrary nesting of julia

@mclarsen mclarsen requested a review from cyrush May 5, 2020 16:46
@coveralls
Copy link

coveralls commented May 5, 2020

Coverage Status

Coverage increased (+0.3%) to 86.384% when pulling 7d3e50d on amr_examples into 13d33e0 on master.

Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, added two naming comments.
Also, we want to move all of the julia stuff (even the non-nestset examples) into a separate source file to help keep them contained.

src/tests/blueprint/t_blueprint_mesh_examples.cpp Outdated Show resolved Hide resolved
src/tests/blueprint/t_blueprint_mesh_examples.cpp Outdated Show resolved Hide resolved
@cyrush cyrush mentioned this pull request May 7, 2020
@cyrush cyrush merged commit 170c3df into master May 7, 2020
@cyrush cyrush deleted the amr_examples branch May 7, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants