Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conduit::utils::format #680

Merged
merged 9 commits into from Jan 19, 2021
Merged

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Jan 15, 2021

Adds conduit::utils::format methods that support fmt style formatting with args encoded in conduit::Nodes.

While generally useful, the primary aim of these functions is to help us support for non-trivial domain maps (#476)

  • add basic docs
  • add python support

@cyrush cyrush added this to the 0.7.0 milestone Jan 15, 2021
@cyrush cyrush added the feature label Jan 15, 2021
@coveralls
Copy link

coveralls commented Jan 15, 2021

Coverage Status

Coverage decreased (-0.2%) to 86.226% when pulling 5fb35e5 on task/2021_01_utils_format_args_and_maps into 3539e80 on develop.

@cyrush cyrush requested review from xjrc and agcapps January 15, 2021 20:03
@cyrush
Copy link
Member Author

cyrush commented Jan 15, 2021

@xjrc @agcapps was hoping for a quick review from someone else, but the update of the docs outputs includes a lot of noise. The most helpful thing would be to read the new docs and see if they make sense. I suspect the easiest way to do so will be after this PR is merged :-).

@cyrush cyrush merged commit 0226f44 into develop Jan 19, 2021
@cyrush cyrush deleted the task/2021_01_utils_format_args_and_maps branch January 19, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants