Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataArray::fill #688

Merged
merged 2 commits into from Feb 1, 2021
Merged

Add DataArray::fill #688

merged 2 commits into from Feb 1, 2021

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented Feb 1, 2021

Resolves #686

@cyrush cyrush added this to the 0.7.0 milestone Feb 1, 2021
@cyrush cyrush added the feature label Feb 1, 2021
@coveralls
Copy link

coveralls commented Feb 1, 2021 •
edited

Coverage Status

Coverage decreased (-0.004%) to 86.222% when pulling 1d93c7e on task/2021_02_data_array_fill into b3d1ba0 on develop.

xjrc
xjrc approved these changes Feb 1, 2021
View reviewed changes
Copy link
Member

@xjrc xjrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's just one small issue in the tests; once that's fixed though, this should be a great new addition!

src/tests/conduit/t_conduit_array.cpp Outdated
va_uint64.fill((uint32) 1);

va_float32.fill((int32) 1.0);
va_float64.fill((int32) 1.0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a mis-copy of the types; I think this should be:

    va_float32.fill((float32) 1.0);
    va_float64.fill((float64) 1.0);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this!

@cyrush cyrush merged commit c038ef3 into develop Feb 1, 2021
@cyrush cyrush deleted the task/2021_02_data_array_fill branch February 1, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xjrc xjrc xjrc approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

add DataArray.fill
3 participants
@cyrush @coveralls @xjrc