Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release notes for 0.7.2 #763

Merged
merged 3 commits into from May 19, 2021
Merged

update release notes for 0.7.2 #763

merged 3 commits into from May 19, 2021

Conversation

cyrush
Copy link
Member

@cyrush cyrush commented May 19, 2021

@xjrc can you review my entry to the release notes about the change to blueprint::verify

@cyrush cyrush requested a review from xjrc May 19, 2021 17:26
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.299% when pulling 43fb506 on task/2021_05_0.7.2_release into d382903 on develop.

@xjrc
Copy link
Member

xjrc commented May 19, 2021

@cyrush: Will try to do this in a bit.

Copy link
Member

@xjrc xjrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; just one small typo to fix.

CHANGELOG.md Outdated
@@ -22,6 +22,9 @@ and this project aspires to adhere to [Semantic Versioning](https://semver.org/s
- Updated to newer version of BLT to leverage CMake's FindMPI defined targets when using CMake 3.15 or newer.
- Changed `rapidjson` namespace to `conduit_rapidjson` to avoid symbol collisions with other libraries using RapidJSON.

#### Blueprint
- The semantics of `conduit::blueprint::mesh::verify` changed. An empty conduit Node is now considered a valid multi-domain mesh with zero domains. If you always expect mesh data, you can add an additional check for empty and to craft code that works for both the old and new verify semantics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...you can add an additional check for empty and to craft code...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cyrush cyrush merged commit f54f834 into develop May 19, 2021
@cyrush cyrush deleted the task/2021_05_0.7.2_release branch May 19, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants