blueprint: added polyhedral_chain example #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrush
approved these changes
Jul 8, 2021
xjrc
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Thanks for adding this, @JustinPrivitera! I have some suggestions for changes; let me know what you think!
|
I'll remove all magic numbers and make changes based on your other feedback |
xjrc
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Just a few last magic numbers to get rid of, but this is looking great! Thanks for making all of these changes, @JustinPrivitera.
|
Sorry about those! I'll get that cleaned up right away |
|
Merged -- thanks @JustinPrivitera ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new example of a polyhedral mesh; this one creates a chain of cubes and triangular prisms. The length of this chain is up to the user.