Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to hsize_t for hdf5 offset and stride #814

Merged
merged 3 commits into from Aug 12, 2021

Conversation

kevinhkhuynh
Copy link
Member

This is a small bug fix for issue #813.

@kevinhkhuynh kevinhkhuynh self-assigned this Aug 10, 2021
@cyrush
Copy link
Member

cyrush commented Aug 10, 2021

thanks @kevinhkhuynh! It looks like there is a python related issue, I'll smooth that out.

@kevinhkhuynh
Copy link
Member Author

thanks @kevinhkhuynh! It looks like there is a python related issue, I'll smooth that out.

Thanks, Cyrus!

@cyrush
Copy link
Member

cyrush commented Aug 12, 2021

python issue was just that it was expecting an exception for neg numbers, we no longer need that check.

@coveralls
Copy link

coveralls commented Aug 12, 2021

Coverage Status

Coverage increased (+0.07%) to 86.423% when pulling 3998c83 on bugfix/conduit-hdf5-offset into 7e6918c on develop.

@cyrush cyrush merged commit a46c532 into develop Aug 12, 2021
@cyrush cyrush deleted the bugfix/conduit-hdf5-offset branch August 12, 2021 02:19
@cyrush
Copy link
Member

cyrush commented Aug 12, 2021

thanks @kevinhkhuynh !

@cyrush cyrush mentioned this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants