-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependencies #31
Fix dependencies #31
Conversation
requirements/release.txt
Outdated
@@ -3,10 +3,12 @@ celery[redis]>=4.3.0 | |||
coloredlogs | |||
cryptography | |||
importlib_resources; python_version < '3.7' | |||
maestrowf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this really needs to be maestrowf>=1.1.5, which doesn't exist yet. so for now, we need to keep maestro install via GitHub develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed. Added in commented-out maestrowf>=1.1.5
to remind us to use it once it exists.
This line here is preventing the direct-from-github maestro being pulled into our zipped files: Line 77 in 65ae4e8
Perhaps we should remove the -e from the maestro install? |
Also this line should include the dev dependencies, so they can be installed via pip install merlin[dev] Line 37 in 65ae4e8
I think we change it to |
No description provided.