Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #31

Closed
wants to merge 9 commits into from
Closed

Fix dependencies #31

wants to merge 9 commits into from

Conversation

ben-bay
Copy link
Contributor

@ben-bay ben-bay commented Dec 4, 2019

No description provided.

@@ -3,10 +3,12 @@ celery[redis]>=4.3.0
coloredlogs
cryptography
importlib_resources; python_version < '3.7'
maestrowf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this really needs to be maestrowf>=1.1.5, which doesn't exist yet. so for now, we need to keep maestro install via GitHub develop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed. Added in commented-out maestrowf>=1.1.5 to remind us to use it once it exists.

@lucpeterson
Copy link
Member

This line here is preventing the direct-from-github maestro being pulled into our zipped files:

rl = [r for r in trl if "-e" not in r]

Perhaps we should remove the -e from the maestro install?

@lucpeterson
Copy link
Member

Also this line should include the dev dependencies, so they can be installed via pip install merlin[dev]

extras = ["mysql"]

I think we change it to ["mysql", "dev"] that'll grab all of the dev dependencies as an extra

@ben-bay ben-bay closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants