Fix pylint errors #403
Closed
Fix pylint errors #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it looks like there are some merge issues that are causing CI to fail (search for <<<<) |
|
This is a big PR! It'll take me some time to parse through it |
|
@lucpeterson A lot of the changes are just to fix pylint errors throughout merlin so most of the files should be quick to review luckily. Above I listed the files that have the more important changes. No rush on this PR, though :) |
bgunnar5
force-pushed
the
bugfix/stop-workers
branch
from
0932085
to
6a0a0b9
Compare
bgunnar5
force-pushed
the
bugfix/stop-workers
branch
from
6a0a0b9
to
a65a81a
Compare
bgunnar5
changed the title
bgunnar5
force-pushed
the
bugfix/stop-workers
branch
from
a65a81a
to
a1cee6a
Compare
This is a combination of 4 commits. fix stop-workers, refactor integration tests, and fix pylint errors fix pylint errors in merlin/ directory fixed minor schema validation bugs fix stop-workers flags and refactor integration tests fix stop-workers flags and refactor integration tests added a mapping getter to MerlinSpec object update gitignore to ignore test outputs add ability to see all tests in table format update integration tests to use a different format and add stop-workers tests fix flags for stop-workers update CHANGELOG add Brian to contributors add a cleanup step to the stop-workers tests fix schema validation bugs pylint fixes to top level of merlin/ dir pylint fixes for merlin/common/ dir pylint fixes for merlin/config/ dir pylint fixes for merlin/examples/ dir pylint fixes for merlin/exceptions/ dir pylint fixes for merlin/server/ dir pylint fixes for merlin/spec/ dir pylint fixes for merlin/study/ dir pylint fixes for tests/integration/ dir pylint configuration changes fix-style changes remove a pylint config option that didn't work add negationchecks to two stop-workers tests update changelog to show pylint fix merge changes from develop fix some merge/pylint issues update github workflow to run all distributed tests modify wording in the docs related to stop-workers new pylint fixes after merging develop fixing issues with rebase fix merge issues that somehow got through remove duplicate entries from changelog
bgunnar5
force-pushed
the
bugfix/stop-workers
branch
from
a1cee6a
to
a173bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes almost all of the pylint errors we were seeing from the
merlin/andtests/directory. I had to update thesetup.cfgfile to include some global disable flags for pylint.