-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RtM] Added py-proj/package.py (RtM = Ready to Merge) #717
Changes from 4 commits
905c240
dc6dc06
94dffd3
552a281
eab87aa
15797aa
9021d3c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from spack import * | ||
|
||
class PyProj(Package): | ||
"""Python interface to the PROJ.4 Library.""" | ||
homepage = "http://jswhit.github.io/pyproj/" | ||
url = "https://github.com/jswhit/pyproj/tarball/v1.9.5.1rel" | ||
|
||
|
||
version('1.9.5.1', 'a4b80d7170fc82aee363d7f980279835') | ||
|
||
# We need the benefits of this PR | ||
# https://github.com/jswhit/pyproj/pull/54 | ||
version('citibeth-latlong2', | ||
git='https://github.com/citibeth/pyproj.git', | ||
branch='latlong2') | ||
|
||
extends('python') | ||
|
||
depends_on('py-cython') | ||
depends_on('py-setuptools') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GitHub formatted the PR in a funny way. But at the end of the file in the
-- Elizabeth On Tue, Apr 5, 2016 at 11:17 AM, Ben Boeckel notifications@github.com
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not using the proj that others are using is going to be a problem as well. There's this libproj4 with the symbol This really needs to use an external proj4. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @tgamblin: I agree on the code sharing. But I don't think there's much to I'm also not comfortable putting a git version in the Spack dev branch,
I can see the following ways forward:
I'm thinking (3) is probably the way forward. Your thoughts? On Tue, May 10, 2016 at 4:39 AM, Todd Gamblin notifications@github.com
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Huh?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So is this one still WIP? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. marked it WIP -- feel free to unmark when ready... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree. But a grep through the repo reveals some confusion over I'll fix the packages below that are mine (glint2, ibmisc, icebin, py-proj).
On Fri, Sep 2, 2016 at 9:26 AM, Adam J. Stewart notifications@github.com
|
||
|
||
# NOTE: py-proj does NOT depends_on('proj'). | ||
# The py-proj git repo actually includes the correct version of PROJ.4, | ||
# which is built internally as part of the py-proj build. | ||
# Adding depends_on('proj') will cause mysterious build errors. | ||
|
||
def install(self, spec, prefix): | ||
python('setup.py', 'install', '--prefix=%s' % prefix) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing licensing info above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a problem? I find tons of packages with missing license info.
On Fri, Sep 2, 2016 at 9:25 AM, Adam J. Stewart notifications@github.com
wrote: