Error Handler Memory Leak

[Steven-Roberts]

If more than default error handler is added to a SUNContext, it does not get free'd in SUNContext_Free.

sundials/src/sundials/sundials_context.c

Line 288 in 2abd63b

SUNErrHandler_Destroy(&(*sunctx)->err_handler);

sundials/src/sundials/sundials_errors.c

Lines 42 to 47 in 2abd63b

	void SUNErrHandler_Destroy(SUNErrHandler* eh)
	{
	if (!eh || !(*eh)) { return; }
	free(*eh);
	*eh = NULL;
	}

Either SUNContext_Free or SUNErrHandler_Destroy should traverse the list of error handlers through sunctx->err_handler->previous to free each.

[gardner48]

sundials/src/sundials/sundials_context.c

Line 288 in 2abd63b

SUNErrHandler_Destroy(&(*sunctx)->err_handler);

This call to SUNErrHandler_Destory should be replaced with SUNContext_ClearErrHandlers

[Steven-Roberts]

Ah great, there's already a function to do that. I swapped in SUNContext_ClearErrHandlers and valgrind reports no leaks. I'll turn it into a PR.

[balos1]

Closed by #467