CMakeLists.txt: Use CMAKE's "Always full RPATH" #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building tests, the test scripts already have RUNPATH set to
${CMAKE_INSTALL_PREFIX}/lib…, which might not be populated yet in
sandboxed builds, so the dynamic linker will fail to find them, and the
tests fail.
By using CMAKE's "Always full RPATH" logic described in
https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/RPATH-handling#always-full-rpath
, we can fix this.
Signed-off-by: Florian Klink <flokli@flokli.de>
flokli
force-pushed
the
cmake-full-rpath
branch
from
ac65392
to
1350421
Compare
10 tasks
|
Included in SUNDIALS 5.5.0. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building tests, the test scripts already have RUNPATH set to
${CMAKE_INSTALL_PREFIX}/lib…, which might not be populated yet insandboxed builds, so the dynamic linker will fail to find them, and the
tests fail.
By using CMAKE's "Always full RPATH" logic described in
https://gitlab.kitware.com/cmake/community/wikis/doc/cmake/RPATH-handling#always-full-rpath, we can fix this.