New Low Order MRI Methods #439

Steven-Roberts · 2024-03-14T22:58:00Z

Adds new 1st-3rd order MRI methods. Most are from the literature, but the rest are trivial to derive, e.g., Euler-based schemes.
Adds some of the base ERK and IRK method tables too. Note that some cannot be equipped with reasonable embeddings.
Fixes an MRI reallocation bug when switching coupling coefficients to one with more stages
Fixes a workspace size bug for MRIStep
Makes MRIStepSetOrder consistent with ARKStepSetOrder and ERKStepSetOrder so that a negative value sets the default order and a positive value out of range prints an error (when method initialization occurs not when SetOrder is called).

Before I update the docs, stability plots, changelog, etc, I want to make sure everyone's ok with these new methods.

…sistent

src/arkode/arkode_butcher_dirk.def

src/arkode/arkode_mristep.c

src/arkode/arkode_mristep_io.c

test/unit_tests/arkode/CXX_serial/ark_test_dahlquist_mri.cpp

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>

… feature/low-order-mri

drreynolds

All of this looks good to me, but this is missing documentation of the new tables, as well as comments in the change log and recent changes files.

include/arkode/arkode_mristep.h

src/arkode/arkode_mristep.c

test/unit_tests/arkode/CXX_serial/ark_test_dahlquist_mri.cpp

Co-authored-by: David Gardner <gardner48@llnl.gov>

drreynolds

One tiny typo, otherwise this looks great.

doc/arkode/guide/source/Butcher.rst

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>

drreynolds

Once all of the CI tests complete, I think that this is good to merge.

Steven-Roberts · 2024-05-08T00:34:42Z

Should be ready to merge now pending the jenkins test and any final reviews

gardner48

Some minor doc updates (I'll make the changes in a sec), otherwise this looks good.

doc/arkode/guide/source/Butcher.rst

doc/arkode/guide/source/Constants.rst

doc/shared/sundials.bib

LLNL/sundials#439

gardner48

Updated the constants table with the new methods and added default first order methods in ERKStep and ARKStep.

Steven-Roberts added 11 commits March 11, 2024 11:20

Add explicit midpoint method

56844ec

Add additional coefficients

e0201e8

Update test output files for Dahlquist test problem

83986c0

Remove extra ERK tables from this branch

9563569

Revert whitespace change

4d7c00e

Fix reallocation bug when changing MRI coupling

a7cab48

Add missing ERK table entry

ea4fe97

Finish adding tables and make MRIStepSetOrder error handling more con…

a1a06de

…sistent

Fix table construction typos

ebe3240

Clean up Dahlquist MRI test

3aec725

Update out files

e1d37eb

Steven-Roberts added bug pkg-ARKODE labels Mar 14, 2024

Steven-Roberts changed the base branch from main to develop March 15, 2024 23:34

drreynolds requested changes Mar 19, 2024

View reviewed changes

Steven-Roberts and others added 8 commits March 19, 2024 11:08

Apply suggestions from code review

71f8795

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>

Revert efun logic

3bb4f08

Merge branch 'feature/low-order-mri' of github.com:LLNL/sundials into…

b7c6872

… feature/low-order-mri

Update ARK test output for Forward Euler after fixing stage bug

9cd3fcb

Fix variable naming following Dan's suggestion

590009f

Add alloc casts back for consistency

f2738c5

Fix integer coefficient

0314b0b

Switch back to calloc+free

43c3e79

drreynolds approved these changes Mar 28, 2024

View reviewed changes

drreynolds self-requested a review March 28, 2024 02:16

drreynolds requested changes Mar 28, 2024

View reviewed changes

gardner48 requested changes Mar 28, 2024

View reviewed changes

include/arkode/arkode_mristep.h Show resolved Hide resolved

src/arkode/arkode_mristep.c Show resolved Hide resolved

test/unit_tests/arkode/CXX_serial/ark_test_dahlquist_mri.cpp Outdated Show resolved Hide resolved

Steven-Roberts and others added 3 commits March 28, 2024 09:55

Update test/unit_tests/arkode/CXX_serial/ark_test_dahlquist_mri.cpp

b4797af

Co-authored-by: David Gardner <gardner48@llnl.gov>

Use static const int for defaults

595a91e

Use consistent alloc style

a68f347

Add publisher to bib entry

0b95ca1

Steven-Roberts mentioned this pull request Apr 10, 2024

Update Dahlquist test for new methods sundials-codes/answers#27

Merged

Steven-Roberts added 2 commits April 10, 2024 16:39

Update answers submodule

246a062

Update Fortran interface

a442f4a

drreynolds previously approved these changes Apr 11, 2024

View reviewed changes

doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved

Steven-Roberts dismissed drreynolds’s stale review via ddbfe62 April 11, 2024 16:01

Steven-Roberts and others added 2 commits April 11, 2024 09:01

Apply suggestions from code review

ddbfe62

Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>

Update answers to fix missing out files in Fortran tests

e7405b5

drreynolds previously approved these changes Apr 11, 2024

View reviewed changes

Steven-Roberts marked this pull request as ready for review April 11, 2024 21:40

Steven-Roberts requested review from balos1 and cswoodward as code owners April 11, 2024 21:40

gardner48 added the update-answers label Apr 17, 2024

balos1 added this to the SUNDIALS Next milestone Apr 19, 2024

Steven-Roberts added 2 commits May 7, 2024 16:45

Update answers

4afeebf

Merge develop

06f5162

Steven-Roberts dismissed drreynolds’s stale review via 06f5162 May 7, 2024 23:50

drreynolds previously approved these changes May 8, 2024

View reviewed changes

Merge branch 'develop' into feature/low-order-mri

6f0de00

gardner48 requested changes May 11, 2024

View reviewed changes

gardner48 pushed a commit to sundials-codes/answers that referenced this pull request May 11, 2024

Update Dahlquist test for new methods (#27)

073b119

LLNL/sundials#439

Apply suggestions from code review

5a686ce

gardner48 dismissed drreynolds’s stale review via 5a686ce May 11, 2024 23:47

gardner48 added 3 commits May 11, 2024 16:49

update answers

c624d92

add missing tables to docs

5c71c50

add missing defaults for first order methods

cd0022f

gardner48 approved these changes May 12, 2024

View reviewed changes

gardner48 merged commit b060541 into develop May 12, 2024
20 checks passed

gardner48 deleted the feature/low-order-mri branch May 12, 2024 03:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Low Order MRI Methods #439

New Low Order MRI Methods #439

Steven-Roberts commented Mar 14, 2024

drreynolds left a comment

drreynolds left a comment

drreynolds left a comment

Steven-Roberts commented May 8, 2024

gardner48 left a comment

gardner48 left a comment

New Low Order MRI Methods #439

New Low Order MRI Methods #439

Conversation

Steven-Roberts commented Mar 14, 2024

drreynolds left a comment

Choose a reason for hiding this comment

drreynolds left a comment

Choose a reason for hiding this comment

drreynolds left a comment

Choose a reason for hiding this comment

Steven-Roberts commented May 8, 2024

gardner48 left a comment

Choose a reason for hiding this comment

gardner48 left a comment

Choose a reason for hiding this comment