Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sundials-codes-addons #444

Merged
merged 24 commits into from
Apr 17, 2024
Merged

sundials-codes-addons #444

merged 24 commits into from
Apr 17, 2024

Conversation

balos1
Copy link
Member

@balos1 balos1 commented Mar 21, 2024 •
edited

Todo:

  • add docs
  • Discuss this on Tuesday.

@balos1 balos1 added the cmake label Mar 21, 2024
@balos1 balos1 marked this pull request as draft March 21, 2024 23:38
@balos1 balos1 marked this pull request as ready for review March 29, 2024 17:12
@balos1
Copy link
Member Author

balos1 commented Mar 29, 2024

I added "captions" to the superbuild toctree (and separated the toctree into multiple) so that different parts of the docs (user guide, developer guide) are more clearly delineated in the sidebar on RTD.

@balos1 balos1 added the docs label Mar 29, 2024
@balos1 balos1 added this to the SUNDIALS Next milestone Mar 29, 2024
gardner48
gardner48 reviewed Mar 31, 2024
View reviewed changes
doc/requirements.txt Outdated Show resolved Hide resolved
gardner48
gardner48 reviewed Mar 31, 2024
View reviewed changes
doc/README.md Outdated Show resolved Hide resolved
@balos1 balos1 requested a review from gardner48 April 4, 2024 19:14
@balos1
Copy link
Member Author

balos1 commented Apr 15, 2024

@gardner48 I think this can be merged now once you approve

gardner48
gardner48 requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes, otherwise this looks good

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
doc/shared/sundials/Install.rst Outdated Show resolved Hide resolved
doc/superbuild/source/contributing/index.rst Show resolved Hide resolved
doc/superbuild/source/contributing/index.rst Outdated Show resolved Hide resolved
doc/superbuild/source/contributing/index.rst Outdated Show resolved Hide resolved
doc/superbuild/source/contributing/index.rst Outdated Show resolved Hide resolved
balos1 and others added 2 commits April 16, 2024 11:08
@balos1 @gardner48
Apply suggestions from code review
ae28456 
Co-authored-by: David Gardner <gardner48@llnl.gov>
@balos1 @gardner48
Update doc/superbuild/source/contributing/index.rst
f672745 
Co-authored-by: David Gardner <gardner48@llnl.gov>
@balos1 balos1 requested a review from gardner48 April 16, 2024 18:09
gardner48
gardner48 requested changes Apr 16, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the change logs need to be updated to note the addition of support for external addons.

@balos1 balos1 requested a review from gardner48 April 16, 2024 23:24
gardner48
gardner48 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Read the docs test is currently failing but that's because of a bug in Sphinx 7.3.0 (released yesterday). A patch was released today so once RTD updates the docs should build again.

@gardner48 gardner48 merged commit 8abf000 into develop Apr 17, 2024
21 of 25 checks passed
@gardner48 gardner48 deleted the feature/sundials-codes-addons branch April 17, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 approved these changes

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

@drreynolds drreynolds Awaiting requested review from drreynolds drreynolds is a code owner

Assignees
No one assigned
Labels
cmake docs
Projects
None yet
Milestone
SUNDIALS Next
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@balos1 @gardner48