Feature: Add option to disable interpolation in ARKODE #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: doc/shared/RecentChanges.rst
This was referenced May 12, 2024
gardner48
commented
May 12, 2024
doc/arkode/guide/source/Usage/ARKStep_c_interface/User_callable.rst
Outdated
Show resolved
Hide resolved
Conflicts: CHANGELOG.md doc/shared/RecentChanges.rst
Co-authored-by: Cody Balos <balos1@llnl.gov>
drreynolds
reviewed
May 21, 2024
Co-authored-by: Daniel R. Reynolds <reynolds@smu.edu>
drreynolds
previously approved these changes
May 23, 2024
balos1
previously approved these changes
May 23, 2024
gardner48
added a commit
to sundials-codes/answers
that referenced
this pull request
May 23, 2024
Conflicts: test/answers
balos1
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for disabling interpolated output in ARKODE steppers by passing
ARK_INTERP_NONEtoARKodeSetInterpolantType. Disabling interpolation can reduce the memory footprint of an integrator by two or more state vectors (depending on the interpolation type and degree) which can be beneficial when interpolation is not needed e.g., when integrating to a final time without output in between or using an explicit fast time scale integrator with MRIStep.When interpolation is disabled, rootfinding is not supported, implicit methods must use the trivial predictor, interpolation at stop times cannot be used, and calls to
ARKodeEvolveinARK_NORMALmode will return at or past the requested output time.