Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Use LAPACK imported target #542

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

gardner48
Copy link
Member

  1. Use LAPACK::LAPACK rather than LAPACK_LIBRARIES
  2. Simplify try_compile test
  3. Don't overwrite LAPACK_WORKS (test every configuration pass)
  4. Use CHECK_START, CHECK_PASSED, and CHECK_FAILED messages in compile test
  5. Replace manual include guard with include_guard(GLOBAL)
  6. Update SundialsTPL.cmake.template with above changes

@gardner48
Copy link
Member Author

This may help address #350.

@gardner48
Copy link
Member Author

gardner48 commented Jul 15, 2024

@balos1 If you're good with the updates to SundialsTPL.cmake.template and LAPACK_WORKS, I'll see about propagating these changes to the other TPL files (in follow on PRs).

With LAPACK_WORKS this is now only used to bypass the compile test and not to indicate if the compile test passed (since failing is a fatal error). So _WORKS might not be the best name, maybe LAPACK_TEST or SUNDIALS_LAPACK_TEST or SUN_LAPACK_TEST (for better namespacing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant