Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage tests #291

Merged
merged 4 commits into from
May 4, 2023
Merged

coverage tests #291

merged 4 commits into from
May 4, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented May 3, 2023

add some additional coverage test and fix an issue with the default units strings from the additional coverage tests

@phlptp phlptp added the bug Something isn't working label May 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #291 (9a4d880) into main (0f2579c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #291      +/-   ##
===========================================
+ Coverage   99.93%   100.00%   +0.06%     
===========================================
  Files           9         9              
  Lines        4624      4626       +2     
===========================================
+ Hits         4621      4626       +5     
+ Misses          3         0       -3     

@phlptp
Copy link
Collaborator Author

phlptp commented May 4, 2023

May address #290

@phlptp phlptp merged commit 3b7c444 into main May 4, 2023
43 checks passed
@phlptp phlptp deleted the coverage_testing branch May 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants