update the match flags to 64 bit #294
Conversation
…itioning, add a minimum partitioning size and better handling of degrees
for more information, see https://pre-commit.ci
| // EXPECT_EQ(ucum | astronomy, allDomains); | ||
| // EXPECT_EQ(ucum | nuclear, allDomains); | ||
| // EXPECT_EQ(nuclear | astronomy, allDomains); |
There was a problem hiding this comment.
Intentionally commented?
There was a problem hiding this comment.
I am changing the domain codes so this relationship doesn't hold at present, there may be further modifications to restore them but not sure what the best approach is yet.
| u1 = unit_from_string("gramm"); | ||
| EXPECT_EQ(u1, precise::g * precise::m); | ||
| u1 = unit_from_string("kilogramm"); | ||
| EXPECT_EQ(u1, precise::kilo * precise::g * precise::m); |
There was a problem hiding this comment.
I feel that this is a very surprising behavior. Mixing full words (kilo and gram) with symbols (m), especially without an operator or spacing in between is not really intuitive and of limited use? Supporting gram*m and gram m seems ok, but gramm?
test/test_unit_strings.cpp
Outdated
| // u1 = unit_from_string("inchy"); | ||
| // EXPECT_EQ(u1,precise::kilo*precise::g*precise::m); |
There was a problem hiding this comment.
there for testing to see what "inchy" actually did, will be removed before merging
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 4626 4655 +29
=========================================
+ Hits 4626 4655 +29 |
phlptp
changed the title
phlptp
force-pushed
the
match_flags_update
branch
from
ece612b
to
9c9c624
Compare
for more information, see https://pre-commit.ci
phlptp
force-pushed
the
match_flags_update
branch
from
4e09db7
to
774d305
Compare
adjust some things with the partitioning, add a minimum partitioning size and better handling of degrees.
Inspired by #293