Fix bugs when comparing and converting gbnds with infinity end points #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing end points 1 with positive infinity and -1 with negative infinity and converting gbnd to ubnd functions ltgQ, gtgQ and u2g failed to check infinity bit. Fix this bug and add related tests.
When comparing end points 1 with positive infinity and -1 with negative infinity and converting gbnd to ubnd functions ltgQ, gtgQ and u2g failed to check infinity bit. Fix this bug and add related tests.
When comparing end points 1 with positive infinity and -1 with negative infinity and converting gbnd to ubnd functions ltgQ, gtgQ and u2g failed to check infinity bit. Fix this bug and add related tests.
Rename id in the comment and remove redundant code in the main function.
|
Thanks for finding this issue and the pull request. The issue was resolved using cmp_gn() which should bring more consistency when comparing endpoints. The test cases supplied were added to tbasic.c alongside other comparison tests instead of creating another test program. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing end points 1 with positive infinity and -1 with negative infinity and converting gbnd
to ubnd, functions ltgQ, gtgQ and u2g failed to check infinity bit.
Fix this bug and add related tests.