Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify_msr_kernel.py #541

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

brandonbiggs
Copy link

Description

It appeared to me that msr_safe was checked twice, once in a location it was not intended to be checked. This was throwing an error for me as I'm not using msr_safe, but did want to run python src/utilities/verify_msr_kernel.py -v per the documentation.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

I didn't have to rebuild to run this change. I also don't have a system with msr_safe installed, so I wasn't able to test if it worked on a system with msr_safe.

  • Test A: Hardware architecture, machine name, example/test run
  • Test B: Hardware architecture, machine name, example/test run
  • ...

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

It appeared to me that msr_safe was checked twice, once in a location it was not intended to be checked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant