[WIP] Use correct installation directory on windows with modern CMake #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmaarrfk
changed the title
|
Follow progress here conda-forge/zfpy-feedstock#6 |
|
@hmaarrfk Sorry for the delay in processing this PR. Currently some tests fail on Travis, ostensibly due to CMake 3.9.4 not supporting FindPython (see https://open.cdash.org/build/6814168/configure). Can we conditionally require CMake 3.12 when |
|
I htink it is likely best to wait until FindPython is supported more fully by scikit-build, then update with that. |
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are willing to update the minimum version of CMake to 3.12, we can work on cleaning this up quite a bit.
Otherwise, happy to keep this here as a WIP