Fix endtoend tests on Cygwin #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #31 +/- ##
==========================================
Coverage ? 92.43%
==========================================
Files ? 46
Lines ? 2248
Branches ? 0
==========================================
Hits ? 2078
Misses ? 170
Partials ? 0Continue to review full report at Codecov.
|
salasoom
force-pushed
the
bugfix/endtoend-cygwin
branch
from
6858867
to
b5fffea
Compare
CMake no longer defines WIN32 on Cygwin. This means that endtoend tests are failing now on Cygwin. To fix that, we have two options: 1) Check if "__CYGWIN__" is defined 2) Use "__unix__" instead of "__linux__". The Unix macro seems to be defined on Cygwin
salasoom
force-pushed
the
bugfix/endtoend-cygwin
branch
from
b5fffea
to
776d89a
Compare
|
I agree with using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake no longer defines
WIN32on Cygwin. This means that endtoend tests are failing now on Cygwin.To fix that, we have two options:
__CYGWIN__is defined__unix__instead of__linux__. The Unix macro seems to be defined on Cygwin