Fixing the hydrator to be in one place and overwriteable #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes a bug with the service-manager laminas/laminas-servicemanager#68 |
matwright
approved these changes
Jan 19, 2021
|
this caused BC break #15 |
svycka
reviewed
Feb 11, 2021
| ), | ||
| 'factories' => array( | ||
| 'lmcuser_register_form_hydrator' => 'lmcuser_user_hydrator', | ||
| 'lmcuser_base_hydrator' => ClassMethodsHydrator::class |
There was a problem hiding this comment.
I guess ClassMethodsHydrator::class does not exist in servicemanager and should be retrieved from hydrators manager as it is hydrator not a service
svycka
added a commit
to svycka/LmcUser
that referenced
this pull request
Feb 11, 2021
rarog
added a commit
to rarog/LmcUser
that referenced
this pull request
Feb 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be BC only config stuff changed - the user hydrator wasn't used at all