Fix inconsistencies in value implementations #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanHealey
force-pushed
the
feature/simple-arg-repearting-arg-consistency
branch
2 times, most recently
from
865c86c
to
27f04ef
Compare
RyanHealey
force-pushed
the
feature/simple-arg-repearting-arg-consistency
branch
from
058db57
to
200a45d
Compare
…s as well as inconsistencies with the api docs
RyanHealey
force-pushed
the
feature/simple-arg-repearting-arg-consistency
branch
from
200a45d
to
5937a8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several inconsistencies between the implementations of methods in
DslParamsImplandRepeatingArgValuesFor example, when calling
value()on a normal parameter that is a list, it will throw an exception. Whereas, in a repeating group it will give the first value. Additionally, within a repeating group, it does not through an error if the parameter does not exist.Additionally,
hasValueinDslParamsImpldid not throw if the param did not exist, instead it returnedfalse, which is different to what is stated in the java doc in the API