Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pictures in doc files are broken #431

Closed
eddieHRS opened this issue Sep 1, 2022 · 2 comments · Fixed by #432
Closed

pictures in doc files are broken #431

eddieHRS opened this issue Sep 1, 2022 · 2 comments · Fixed by #432

Comments

@eddieHRS
Copy link

eddieHRS commented Sep 1, 2022

Though it is not a functional bug, but brings bad experience while reading docs. ^_^

@swarren12
Copy link
Contributor

Hi,

Is this all images or only certain ones?

Are you reading the docs in the browser at https://lmax-exchange.github.io/disruptor/ or generating them locally using the Gradle script?

Thanks

@eddieHRS
Copy link
Author

eddieHRS commented Sep 1, 2022

Hi,

Is this all images or only certain ones?

Are you reading the docs in the browser at https://lmax-exchange.github.io/disruptor/ or generating them locally using the Gradle script?

Thanks

i think all pictures are broken. And i generate them locally with a IDEA plugin. ^_^

More: if i add :imagesdir: ../../../resources/images/ and change image::../resources/images/user-guide/models.png[] to image::user-guide/models.png[] in file src/docs/asciidoc/en/user-guide/10_using_the_disruptor.adoc. it works.

swarren12 added a commit to swarren12/disruptor that referenced this issue Sep 1, 2022
@Palmr Palmr closed this as completed in #432 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants