Skip to content

Commit

Permalink
Add support for HiDPI screens
Browse files Browse the repository at this point in the history 
Per #3814
  • Loading branch information
@tresf
tresf committed Sep 20, 2017
1 parent 0382b69 commit 8bc9e9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/linux/package_linux.sh.in
View file
Expand Up @@ -106,7 +106,7 @@ if lsmod |grep vboxguest > /dev/null 2>&1; then
echo "VirtualBox detected. Forcing libgl software rendering."
export LIBGL_ALWAYS_SOFTWARE=1;
fi
QT_X11_NO_NATIVE_MENUBAR=1 \$DIR/usr/bin/lmms.real "\$@"
QT_X11_NO_NATIVE_MENUBAR=1 QT_AUTO_SCREEN_SCALE_FACTOR=1 \$DIR/usr/bin/lmms.real "\$@"
EOL

chmod +x "${APPDIR}usr/bin/lmms"
Expand Down

13 comments on commit 8bc9e9d

@lukas-w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this flag again? Qt 5.8 falsely detects the scaling for me, rendering LMMS AppImages unusable on my system with no way to change the behaviour.

image

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we bump them to 5.9 then and solve both problems?

@lukas-w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if 5.9 solves it, I'll test it in a minute.

@lukas-w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "solve both problems"?

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your feedback from 5.9 in #3814 is what allowed merge. We can also use a conditional in the AppRun against qmake, although version parsing may be challenging inside the bash script.

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I'm comparing Mac vs. Linux feedback. If you can test that would be great. Whatever works best I guess. :)

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "solve both problems"?

The newly discovered one (unusable on your machine) as well as the old one (support HiDPI).

@lukas-w
Copy link
Member

@lukas-w lukas-w commented on 8bc9e9d Nov 25, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Qt5.9 fixes it.

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3925

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped Qt to 5.9 via d0194e6.

@falkTX
Copy link
Contributor

@falkTX falkTX commented on 8bc9e9d Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using the latest AppImage build, and can report scaling is not working correctly on my system (Ubuntu 16.04 based, using KDE5 neon)

It's a laptop with an external screen connected.
On the laptop screen, LMMS looks like this:

screenshot_20171201_122349

Now on the external screen LMMS looks like this:

screenshot_20171201_122443

I have no scaling whatsoever enabled on this system.
LMMS is unusable on both screens :(

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll turn off QT_AUTO_SCREEN_SCALE_FACTOR then for now. People can always flag it back on manually. I'll add this to the Carla PR and upload a new AppImage.

@tresf
Copy link
Member Author

@tresf tresf commented on 8bc9e9d Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppImage link updated in #4026 with this change applied.

Please sign in to comment.