(Windows) Non-ASCII String Displaying Bug #1325

Closed
LYF610400210 opened this Issue Nov 18, 2014 · 2 comments

Projects

None yet

3 participants

@LYF610400210
Contributor
  1. I put zh.qm into C:\Program Files\LMMS\data\locale\.
  2. Click on the Automation Track.
  3. Hold Ctrl and drag the block.

E?n?c?o?d?i?n?g?

E?n?c?o?d?i?n?g?

按住<Ctrl> ... -> ??<Ctrl>???

@LYF610400210 LYF610400210 changed the title from [Windows 1.0.3] Non-ASCII String Displaying Bug? to [Windows]1.0.3 Non-ASCII String Displaying Bug Nov 21, 2014
@LYF610400210
Contributor

And Japanese:

Japanese

@tresf tresf added the bug label Nov 21, 2014
@tresf tresf added this to the 1.2.0 milestone Nov 21, 2014
@tresf tresf changed the title from [Windows]1.0.3 Non-ASCII String Displaying Bug to (Windows) Non-ASCII String Displaying Bug Dec 22, 2014
@softrabbit
Member

I'm pretty sure that's your problem: https://github.com/LMMS/lmms/blob/master/src/gui/StringPairDrag.cpp#L55

http://doc.qt.io/qt-4.8/qstring.html#toLatin1

The returned byte array is undefined if the string contains non-Latin1 characters. Those characters may be suppressed or replaced with a question mark.

Fix coming up later...

@tresf tresf closed this in #1933 Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment