Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Windows) Non-ASCII String Displaying Bug #1325

Closed
ghost opened this issue Nov 18, 2014 · 2 comments
Closed

(Windows) Non-ASCII String Displaying Bug #1325

ghost opened this issue Nov 18, 2014 · 2 comments
Labels
bug
Milestone

Comments

@ghost
Copy link

@ghost ghost commented Nov 18, 2014

  1. I put zh.qm into C:\Program Files\LMMS\data\locale\.
  2. Click on the Automation Track.
  3. Hold Ctrl and drag the block.

E?n?c?o?d?i?n?g?

E?n?c?o?d?i?n?g?

按住<Ctrl> ... -> ??<Ctrl>???

@ghost ghost changed the title [Windows 1.0.3] Non-ASCII String Displaying Bug? [Windows]1.0.3 Non-ASCII String Displaying Bug Nov 21, 2014
@ghost
Copy link
Author

@ghost ghost commented Nov 21, 2014

And Japanese:

Japanese

@tresf tresf added the bug label Nov 21, 2014
@tresf tresf added this to the 1.2.0 milestone Nov 21, 2014
@tresf tresf changed the title [Windows]1.0.3 Non-ASCII String Displaying Bug (Windows) Non-ASCII String Displaying Bug Dec 22, 2014
@softrabbit
Copy link
Member

@softrabbit softrabbit commented Mar 31, 2015

I'm pretty sure that's your problem: https://github.com/LMMS/lmms/blob/master/src/gui/StringPairDrag.cpp#L55

http://doc.qt.io/qt-4.8/qstring.html#toLatin1

The returned byte array is undefined if the string contains non-Latin1 characters. Those characters may be suppressed or replaced with a question mark.

Fix coming up later...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.