Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Calf Vintage Delay freezing #1333

Closed
kpone33 opened this issue Nov 19, 2014 · 19 comments
Closed

Random Calf Vintage Delay freezing #1333

kpone33 opened this issue Nov 19, 2014 · 19 comments

Comments

@kpone33
Copy link

kpone33 commented Nov 19, 2014

In the current versions of LMMS the LADSPA effect Calf Vintage Delay is sometimes 'freezing' (stopping to make any sound). The freezing happens when there's no more sound coming into the effect like when there's no more note being played by any instrument on an FX channel. I've tested this with older versions as well and it exists since version 1.0.0. In version 0.4.14 this problem was not present.

This occurs on versions 1.0.0 and above on Windows 32 and 64 bit versions. Latest version I've tested is the current beta version 1.0.96

@tresf tresf added the bug label Nov 19, 2014
@tresf tresf added this to the 1.1.0 milestone Nov 19, 2014
@diizy
Copy link
Contributor

diizy commented Nov 20, 2014

On 11/20/2014 01:28 AM, kpone33 wrote:

In the current versions of LMMS the LADSPA effect Calf Vintage Delay
is sometimes 'freezing' (stopping to make any sound). The freezing
happens when there's no more sound coming into the effect like when
there's no more note being played by any instrument on an FX channel.
I've tested this with older versions as well and it exists since
version 1.0.0. In version 0.4.14 this problem was not present.

This occurs on versions 1.0.0 and above on Windows 32 and 64 bit
versions. Latest version I've tested is the current beta version 1.0.96

Sounds like denormals...

@tresf new build?

@tresf
Copy link
Member

tresf commented Nov 20, 2014

@tresf new build?

Yeah, we're definitely ready since the mixer bug is now closed.

Per Lukas, it's all done via releases now. We'll see if the builds upload. Should be about 15 minutes per build.

https://github.com/LMMS/lmms/releases/tag/v1.0.98

@tresf
Copy link
Member

tresf commented Nov 20, 2014

Hmm... 30 minutes, no win builds...

@lukas-w, per above comment, should Pre-releases build and upload automatically?

@lukas-w
Copy link
Member

lukas-w commented Nov 20, 2014

Hmm I kind of knew it wouldn't work. It may be that .travis.yml doesn't support wildcards:

deploy:
    files: lmms-*-win*.exe

We could try writing this instead:

    files:
        - lmms-1.0.98-win32.exe
        - lmms-1.0.98-win64.exe

This would imply that we'll have to change those lines every release though.

@lukas-w
Copy link
Member

lukas-w commented Nov 20, 2014

Oh, nsis was missing.

@lukas-w
Copy link
Member

lukas-w commented Nov 20, 2014

Working now, both builds landed! :)

    files: lmms-${TRAVIS_TAG:1}-$TARGET_OS.exe

Note that this requires the tag to always be the version number, preceded by a 'v': v1.0.98

@tresf
Copy link
Member

tresf commented Nov 20, 2014

@lukas-w fantastic. What a great feature.

Back on topic... @kpone33 can you please try to reproduce the issue with this latest beta version: https://github.com/LMMS/lmms/releases/tag/v1.0.98

This version contains a patch which may fix the bug. Please uninstall all other versions prior to testing.

-Tres

@kpone33
Copy link
Author

kpone33 commented Nov 20, 2014

@tresf I just downloaded that version and it still happens in that version. As you said I uninstalled all other versions before, but that didn't fix it.

@tresf
Copy link
Member

tresf commented Nov 20, 2014

Thanks. We'll leave this one open. Thanks again for the detailed bug report.

@grejppi
Copy link
Contributor

grejppi commented Nov 22, 2014

Sounds like autoquit kicking in. There is a way around in master ("Keep effects running even without input" in settings) but not in stable-1.1...

Tough luck.

@grejppi
Copy link
Contributor

grejppi commented Nov 22, 2014

Oh, almost forgot: turning up the Decay knob of the delay in the effect rack may help a bit.

@diizy
Copy link
Contributor

diizy commented Nov 23, 2014

On 11/23/2014 12:50 AM, grejppi wrote:

Sounds like autoquit kicking in. There is a way around in |master|
("Keep effects running even without input" in settings) but not in
|stable-1.1|...

The way around in 1.1 is to tweak the effect's decay knob, just like it
has been since ages... disabling autoquit isn't an option for everyone
(we don't all have high-end hardware).

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 23, 2014

Why do you leave out "Keep effects running even without input" - setting in 1.1? That was coded long time ago

@grejppi
Copy link
Contributor

grejppi commented Nov 23, 2014

That was not my decision.

@Sti2nd
Copy link
Contributor

Sti2nd commented Nov 23, 2014

I know, maybe no one decided anything, it just never made it because we forgot it probably.

@diizy
Copy link
Contributor

diizy commented Nov 23, 2014

On 11/23/2014 01:59 PM, grejppi wrote:

That was not my decision.

Feel free to cherrypick it to 1.1 if you want to... probably it won't
disturb things too much.

@tresf
Copy link
Member

tresf commented Dec 23, 2014

Bumping to 1.2. Not sure if this is considered fixed or not in master (does this check box fix it or is it just a work-around?)

@tresf tresf modified the milestones: 1.2.0, 1.1.0 Dec 23, 2014
@curlymorphic
Copy link
Contributor

Bumping to 1.2. Not sure if this is considered fixed or not in master (does this check box fix it or is it just a work-around?)

what is the current status with this?

@tresf
Copy link
Member

tresf commented Mar 9, 2015

Almost certainly a duplicate of #643. Marking as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants