Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat. req. ARP Sync timings #1836

Open
oeai opened this issue Mar 8, 2015 · 11 comments
Open

Feat. req. ARP Sync timings #1836

oeai opened this issue Mar 8, 2015 · 11 comments
Milestone

Comments

@oeai
Copy link
Contributor

oeai commented Mar 8, 2015

we can change arpeggio period only in time (ms) right now
i propose to sync it with current tempo, so it was like 1\64 1\16 1\2 and so on
i thought that sync mode (Sort, Sync) can do that, but it's not, sync time is still in ms that is very hard to handle with current beat.

@softrabbit
Copy link
Member

Right-click the time knob and there should be a tempo sync submenu in the context menu.

@curlymorphic
Copy link
Contributor

This is already implemented.

If you right click on the time knob, Tempo Sync, choose timing. This could be handled in a better way though

@tresf
Copy link
Member

tresf commented Mar 8, 2015

Just a guess, but he may be observing the failure to ever round-robin sync from start to finish in conjunction with a major chord and a standard 4/4 measure. (try it out)

I can draw a picture if you'd like.

@curlymorphic
Copy link
Contributor

@tresf you mean that a major chord is played in 3/4 time ish? maybe pics would help please.

Oh, now ive sat here for a bit,I can here it drifting.

@tresf
Copy link
Member

tresf commented Mar 8, 2015

It behaves as described. It's just math. Count the number of notes in a major chord up and then back down, versus the number of slots... The alignment never works out on a standard measure because the C note only gets played once. :)

@curlymorphic
Copy link
Contributor

I agree that is incorrect, but changing that would break backwards compatibility.

@tresf
Copy link
Member

tresf commented Mar 8, 2015

It is technically correct. What we could possibly do is increase the chord progression by the appropriate notes to match, but make it an ARP checkbox setting perhaps?

@curlymorphic
Copy link
Contributor

It is technically correct. What we could possibly do is increase the chord progression by the appropriate notes to match, but make it an ARP checkbox setting perhaps?

Yes thats a good idea. we would need to work out how to handle this for various note counts and time signatures.

@tresf tresf added this to the 1.3.0 milestone Mar 8, 2015
@oeai
Copy link
Contributor Author

oeai commented Mar 8, 2015

if we take abstract note and divide it into shares (quantitze) without counting current tempo, then this case can be solved with quantization (1-128).
the other way is in recalculating ms timings with tempo \ period change

@tresf tresf mentioned this issue Jun 3, 2015
7 tasks
@zonkmachine
Copy link
Member

@oeai I think it really sounds like you're describing the sync function we already have as described in the two first answers in this thread.
temposync

@zonkmachine
Copy link
Member

I can draw a picture if you'd like

I would like that plz , but if I understand you right you want the chord to progress up fully to the base note one octave above and then back? It's just a matter to change (code here):
const int range = (int)( cur_chord_size * m_arpRangeModel.value();
to
const int range = (int)( cur_chord_size * m_arpRangeModel.value() + ( bool m_addOneForFunk );

Also, as Vesa commented here, we could implement this with a knob to more fine grained set the range.
I'll try both these option out. I'm currently just testing the arpeggiator with const int range = (int)( cur_chord_size * m_arpRangeModel.value() + 1; and it sounds totally worthwile it imho.

@zonkmachine zonkmachine self-assigned this Sep 6, 2016
@zonkmachine zonkmachine removed their assignment Apr 11, 2017
@Spekular Spekular modified the milestones: 1.3, 1.3+ Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants