Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak Controller Mute Effect Behavior #3017

Open
tresf opened this issue Sep 4, 2016 · 15 comments
Open

Peak Controller Mute Effect Behavior #3017

tresf opened this issue Sep 4, 2016 · 15 comments

Comments

@tresf
Copy link
Member

tresf commented Sep 4, 2016

Peak controller has a toggle called "Mute Effect".

I would expect the behavior to disable the controller entirely, however instead of muting the Peak Controller effect it instead mutes the instrument it is monitoring. Is this intended?

untitled

@grejppi
Copy link
Contributor

grejppi commented Sep 4, 2016

👍 Mute implies silence, but Mute Effect is confusing.

I think it would make sense to add a Bypass toggle there as well (to have all in one place) and rename this one to Mute.

@Spekular
Copy link
Member

Spekular commented Sep 4, 2016

I'm pretty sure it's intentional. If you're using the peak controller for an effect rather than for mixing you might not want the input audible. For example if you want to duck the same amount for kicks and snares you could set up a separate track with just one sample that's used to control the duck. Or maybe you want "ghost drums" that are only present via the ducking they cause.

@tresf
Copy link
Member Author

tresf commented Sep 4, 2016

If you're using the peak controller for an effect rather than for mixing you might not want the input audible.

I realized that after reading @grejppi's answer and decided not to comment. I'm not sure how best to illustrate this concept in a few words. I do believe that Mute Effect can have many interpretations. I believe Mute Source may be more appropriate, but if it were REALLY being muted, the controller would stop responding to input... 😕

@Spekular
Copy link
Member

Spekular commented Sep 4, 2016

I definitely agree that the wording is odd. I know "ghost X" is kinda overused, but "Ghost input" gets the point across I think?

@jasp00
Copy link
Member

jasp00 commented Sep 4, 2016

Mute Output? Discard Sound? Perhaps a What's This? should be added.

@vlad0337187
Copy link

I think, that the "Mute effect" must mute only the effect, produced by this plugin (the same as "bypass").
And if there will be button "mute", than plugin will not listen to input, on it's output will be nothing, consequently, on the output of mixer will be nothing.

@Spekular
Copy link
Member

Spekular commented Sep 9, 2016

Why exactly do we need a LED to turn off the effect inside when you could do that in the effect rack? I feel like this would cause unnecessary confusion, especially if it keeps the old name and changes functionality.

@tresf
Copy link
Member Author

tresf commented Sep 9, 2016

Why exactly do we need a LED to turn off the effect inside when you could do that in the effect rack? I feel like this would cause unnecessary confusion, especially if it keeps the old name and changes functionality.

Agreed.

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 10, 2016

What's about "listen"?

@Umcaruje
Copy link
Member

I vote for Mute Output, its exactly what the button does, and it doesn't change a lot from the current label, which I think is important to not confuse the users.

@BaraMGB
Copy link
Contributor

BaraMGB commented Sep 10, 2016

@Umcaruje actually it mutes the trigger signal so one can listen to the modulated signal. I guess there aren't "two words" which describes what happens if one click on this button. The user has to listen by him/her self to understand. Therefore "listen" is a good choice I think.

@BaraMGB
Copy link
Contributor

BaraMGB commented Jan 16, 2017

I want to bring this back into conversation.

@Sawuare
Copy link
Member

Sawuare commented Feb 22, 2018

it mutes the trigger signal so one can listen to the modulated signal.

Then how about "Mute output audio"?

@Umcaruje
Copy link
Member

Redundant, it's the same as "Mute output" since we're always talking about audio here

@Spekular
Copy link
Member

Spekular commented Feb 22, 2018 via email

@Sawuare Sawuare removed the ux label Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants