Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TabWidget resizable #4896

Closed
JohannesLorenz opened this issue Mar 14, 2019 · 3 comments
Closed

Make TabWidget resizable #4896

JohannesLorenz opened this issue Mar 14, 2019 · 3 comments
Assignees
Milestone

Comments

@JohannesLorenz
Copy link
Contributor

In order to have variable sized control widgets in instrument windows for Lv2, we need its TabWidget (the one containing "Plugin", "Envelope, Filter & LFO", "Chord stacking & arpeggio" etc...) to be resizable. Currently it limits all its tabs to its own size and cuts them if required. In the end, it must have the maximum size of all tabs as minimum size.

There are two options:

  • 👀 : add a boolean "fixedSize" to TabWidget's ctor
  • 🚀 : Completely change TabWidget to always resize to fit its children.

Obviously, 🚀 will force us to fix a few more TabWidgets in LMMS. That will mean extra work, though it makes the TabWidget code less complex.

@he29-net
Copy link
Contributor

You could implement the switch like @michaelgregorius described at #2847 (comment)
I already use his solution for the new spectrum analyzer, so implementing it for the TabWidget this way would make the "resizability switch" more consistent across other classes.

@JohannesLorenz
Copy link
Contributor Author

I've implemented this with a boolean parameter. Will link the PR soon.

@JohannesLorenz
Copy link
Contributor Author

Closing, as this is done in PR #4906

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants