Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export artefact with echo in zasfx #5135

Open
musikBear opened this issue Aug 19, 2019 · 11 comments
Open

export artefact with echo in zasfx #5135

musikBear opened this issue Aug 19, 2019 · 11 comments
Labels

Comments

@musikBear
Copy link

LMMS 1.2.0 64B WIN10
listen to this export. The hiss is an artefact
artefacts.zip
Also same hiss a in 24b and 32b
Export settings: default
I think its resonance?

@SecondFlight
Copy link
Member

This can't be diagnosed unless we have steps to reproduce and/or a project file. Please provide at least one of those.

@SecondFlight SecondFlight added the response required A response from OP is required or the issue is closed automatically within 14 days. label Aug 19, 2019
@musikBear
Copy link
Author

file yes of-cause (added
I have digged in, and the export-artefact emerges, when Echo-effects are added :
Edit-instrument| Effect| Echo

artefacts.zip

@no-response no-response bot removed the response required A response from OP is required or the issue is closed automatically within 14 days. label Aug 19, 2019
@PhysSong PhysSong added the bug label Oct 1, 2019
@PhysSong
Copy link
Member

PhysSong commented Oct 1, 2019

Confirmed. Here's the comparison of exported(top) and normally played(bottom) audio samples.
image

@PhysSong
Copy link
Member

PhysSong commented Oct 1, 2019

The issue is from the fact that the delay time of the Zyn echo uses forward writing(instead of backward reading) and interpolates the value of the time.
Suppose there's a note at the beginning of the project. When exporting it, Zyn starts to interpolate the delay time. At the same time, Zyn plays the note and applies the echo effect. It results in the mentioned artifact.
The upstream worked around by disabling the interpolation(zynaddsubfx/zynaddsubfx@b4f6091), but I'm not sure if it's the best way. It's almost impossible to avoid artifacts when automating the delay time, so I think there're no perfect ways to handle it.

@musikBear
Copy link
Author

Excellent dissect 👍

@onpon4
Copy link

onpon4 commented Oct 19, 2022

Hi, so this little bug is one that's caused me inconvenience before. I don't really fully understand the technicalities of it, but I know that I only get this noticeably when a Zyn note is played right at the start of the track, so I work around this by shifting everything over, exporting, and then trimming off the silence at the beginning (it's tedious, but it works). Would it be possible to automate a sort of hack like this to solve the problem? (Not necessarily that exact procedure, but some trickery so that the thing Zyn does to cause the artifact behaves as if there's silence at the beginning of the track.)

🦇

@musikBear
Copy link
Author

I work around this by shifting everything over, exporting, and then trimming off the silence at the beginning (it's tedious, but it works).

Try to simply set loopmarkers covering exactly the whole project, and then use Export-between-loopmarkers, in the export-dialog. Let us know if that also works

@onpon4
Copy link

onpon4 commented Oct 20, 2022

Try to simply set loopmarkers covering exactly the whole project, and then use Export-between-loopmarkers, in the export-dialog. Let us know if that also works

Nope, that doesn't lead to any improvement. In fact, if I do my solution of shifting everything over by one but export by loop markers starting at the real start position (after the bit of silence I insert at the start), that creates the same artifact as if I exported normally with everything in its original position. The only way I have no artifact is if the start of the audio being exported isn't playing a Zyn note (and presently the easiest way to do that is to make it have a bit of silence at the start and then trim off that bit of silence with Audacity or whatever).

🦇

@musikBear
Copy link
Author

Nope, that doesn't lead to any improvement.

Can you make a dummy project with the artefact.
You can upload .MMP files right here.

@onpon4
Copy link

onpon4 commented Oct 20, 2022

Well there shouldn't be a need to, you already posted such a project file with the same artifact (#5135 (comment)). Is there any particular reason that one is inadequate?

🦇

@musikBear
Copy link
Author

No its just me that is inadequate
Over & out 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants