Many file menu actions use incorrectly sized icons

[Spekular]

Bug Summary

File menu icons should be 16x16 in order to display pixel perfect. Only two of the actions in the file menu are actually at this size.

Screenshot

Image key:

• Red: Icon is not available in the correct size
• Orange: Icon is available in the correct size, but uses a 20x20 icon instead
• Blue: Icon is not available in the correct size, uses 15x15 icon
• Green: Icon of correct size is used

Proposal

I think this is a symptom of poor organization of icons. Icon file names don't indicate their size, nor are they organized in subfolders by size. I think the rendered icons in the theme ought to be split into folders by size. Then we can have something like 16x16/project_save and 20x20/project_save, which would make it very clear which size is in use.

I'm unsure of the best way to organize the different sizes when it comes to the source .svg files. If I'm not mistaken, we intended to make each icon its own file? Perhaps all size variations could be kept in one file, or perhaps they should mirror the structure of the exported images.

[ryuukumar]

Does LMMS code default to higher res pixmaps or 16x16 pixmaps? If it's the former the orange should be an easy fix imo.

[Spekular]

I don't believe there's any defaulting at all, pixmaps are selected directly by their filename from what I can tell (with .png excluded)

[qnebra]

I looked into icons:

• "project new" had only 20x20 variant. Looked more into it. Correct size have other filename.
• "project open' had only 20x20 variant
• "project open recent" have 16x16 variant
• "project save" have only 20x20 variant
• "project import" have 16x16 variant
• "project export" have only 20x20 variant. I prepared correct size, matching with "project import" icon.