Effect modules show folder names

[sound8]

When you setup your effect folder location in settings, if that folder has folders within it, the names of these folders will show up in the Effect Module names <effect name>
For example SPACE\REVERB\Plate Reverb

Just in case this does not make sense, I am referring to the Effect modules that show up in the Mixer - Effect Chains as well as the ones in Instruments - Effects tab.
The white text name at the bottom of each effect module inserted into them.

Think I would prefer not to show the folder path within the names
This is more of just a preference, not sure if others will agree?

EDIT
also forgot to mention that adding the folder names to beginnings can make the actual effect names get cut off on the right side so you can't see the names of the effects (if names are too long).

[Spekular]

It is a little bit weird that we show folders in the rack but not when browsing for effects. Personally I'd be fine with an option to hide the folder in the rack, but I think it should be possible to check because:

• If you have multiple versions of an effect it's good to know which one is loaded
• If an effect won't load it's good to know where it's expected to be found

[sound8]

Thank you for your response and for agreeing with me.

I like that it shows the path in the "Add effects" window, that of course should stay.
When it comes to your concern, I think I have the answer....

It can be removed from Effect module name and the way to determine which version you are running can be seen by right clicking on the effect module, at the top of the context menu it shows the location path and name of the effect already :)
Would this work for you/others?

[Spekular]

Oh, you're right, it's already visible there.

Marking this as a good first issue as it should just be a matter of checking how the Add Effect menu gets the name and doing the same thing in the effect rack code.

[tresf]

@Spekular can you clarify what this is asking. To show them, not to show them or to make them consistent throughout? If it's too long, I recommend we make it a tooltip with the full path and then show the sorter version in the UI. I agree that the folders add value and should be easy to figure out, even if it's an extra click or hover.

I strongly discourage against any toggle option for this but instead leverage sane defaults with an option to view more info if needed.

[Spekular]

@Spekular can you clarify what this is asking. To show them, not to show them or to make them consistent throughout?

Effects in effects racks should not show directory structure.

[musikBear]

Effects in effects racks should not show directory structure.
Not?! show path?
I dont like that. It is info about a component, that is not available any where else, and the realestate is available on the button. However the name of the plugin is redundant!

The name (red underline) is present twice, so the line

could be omitted, without loosing info

[Spekular]

@musikBear the screenshot you're referencing is the effects browser, not the rack.

[Spekular]

It is info about a component, that is not available any where else

As mentioned earlier in the discussion, it's at the top of the context menu when you right click an effect.

the realestate is available on the button

Unless you have a long effectname and/or path.

However the name of the plugin is redundant!

Maybe it is now, but VST provides a name that may differ from the .dll filename. This name is used for the title of the effect's window, so it should be used in the name field and rack as well.

[musikBear]

the screenshot you're referencing is the effects browser, not the rack.

I screenshot the image from your post, #5748 (comment)
Then drawed on it
Can you picture my confusion .. nvm... ;)

[eliaslk]

Hello! I'm a first-time contributor and would love to try my hand at this issue if it is still available.

[Spekular]

@eliaslk go ahead! I've assigned this issue to you, but feel free to unassign yourself should you decide that you no longer want to work on it :)

[Monospace-V]

For reference, I find it in the mmp file here.

Under the "attribute value" tag.

I found this when editing a file from a friend for fitting my directory structure.
I think that making this value user-modifiable will allow us to rename effects too: useful, so one can tell which effect does what without being forced to open it and figure out the parameter values.
But that is an aside- though it seems related, as one can do it manually by changing the attribute value.

[tresf]

making this value user-modifiable will allow us to rename effects

For portability reasons, we should not allow the renaming of effects through LMMS, or if we add this feature, it should yield a warning flag that it can/will break things.

An argument could be made that if a plugin is missing, we should offer the ability to resolve the missing plugin through UI, but this should be done carefully as we don't want to send values to a plugin that it wasn't intended for.

[Monospace-V]

For portability reasons, we should not allow the renaming of effects through LMMS, or if we add this feature, it should yield a warning flag that it can/will break things.

An argument could be made that if a plugin is missing, we should offer the ability to resolve the missing plugin through UI, but this should be done carefully as we don't want to send values to a plugin that it wasn't intended for.

I don't quite understand how it could break things in case of portability. I mean renaming individual FX instances would be useful, to clarify. Usecases like "Underwater EQ," "brightness EQ", "small room," "tunnel echo"; as opposed to the usual "Equalizer," "Equalizer," "DD Reverb," "Multitap echo," the latter set of which isn't descriptive about the instruments.
Like how one can rename an instrument track, whether it's a native plugin or VST, renaming an effect to describe what it is.
This seemed like the parameter to change- when I accidentally changed it, it reflected in the project when I opened it.

I believe have misunderstood the purpose of the attribute tag. Upon checking project files, I only find the attribute tag available on VSTs. So that part of my original comment is also useless.
(However, I still don't quite understand how renaming effects could break things...)

Changing the attribute tag on a VST changes the display name, but there is no similar tag on a native plugin.
Never mind.

[tresf]

@Monospace-V Sorry I misunderstood. Yeah I think what you are describing is more of an "effect preset" (or perhaps just a visual). This bug report is more around the file path AFAIR. My concerns are only in regards to changing the file path through the UI. I agree that having reusable presets is definitely something we need, I just don't think it's in scope of this particular bug report.