New LADSPA control dialog too tall on low-res screens for plugins with many controls #6982
Labels
Comments
|
could the theme be a thing? |
It isn't much better at all with the default theme |
michaelgregorius
added a commit
to michaelgregorius/lmms
that referenced
this issue
Dec 8, 2023
Remove the code which computes a minimum height for the LADSPA dialogs. It was intended to make sure that no scrollbar is shown in most cases. However, doing so came at the cost that the computed height was the minimum height as well. Therefore the dialogs took a lot of space on low-res displays and could not be made smaller. After the removal the behavior is still sane. Small dialogs are shown in full and dialogs which are larger, e.g. "Calf Equalizer 12 Band LADSPA", seem to be sized around half the height of the workspace and show scrollbars.
|
Hi @kamkamkamkamkamkamkamkam, this problem should be fixed with pull request #7019. |
michaelgregorius
added a commit
that referenced
this issue
Dec 31, 2023
Remove the code which computes a minimum height for the LADSPA dialogs. It was intended to make sure that no scrollbar is shown in most cases. However, doing so came at the cost that the computed height was the minimum height as well. Therefore the dialogs took a lot of space on low-res displays and could not be made smaller. After the removal the behavior is still sane. Small dialogs are shown in full and dialogs which are larger, e.g. "Calf Equalizer 12 Band LADSPA", seem to be sized around half the height of the workspace and show scrollbars.
|
Hi @kamkamkamkamkamkamkamkam! I have just merged a fix with pull request #7019. If you still encounter problems please reopen this issue or create a new one. |
sakertooth
pushed a commit
to sakertooth/lmms
that referenced
this issue
Jan 5, 2024
Remove the code which computes a minimum height for the LADSPA dialogs. It was intended to make sure that no scrollbar is shown in most cases. However, doing so came at the cost that the computed height was the minimum height as well. Therefore the dialogs took a lot of space on low-res displays and could not be made smaller. After the removal the behavior is still sane. Small dialogs are shown in full and dialogs which are larger, e.g. "Calf Equalizer 12 Band LADSPA", seem to be sized around half the height of the workspace and show scrollbars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It'd be really nice to be able to shrink these these for those of us using resolutions under 1080p (screenshot is 1366x768)
The text was updated successfully, but these errors were encountered: